Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 | Add MQTT component to support control via Smart Home solution #1963

Open
c0un7-z3r0 opened this issue Jan 29, 2023 · 5 comments · May be fixed by #2412
Open

🚀 | Add MQTT component to support control via Smart Home solution #1963

c0un7-z3r0 opened this issue Jan 29, 2023 · 5 comments · May be fixed by #2412
Labels
enhancement future3 Relates to future3 development help wanted
Milestone
v3.7

Comments

@c0un7-z3r0
Copy link
Contributor

c0un7-z3r0 commented Jan 29, 2023 •
edited
Loading

Feature Description

Add MQTT component to Future3.

What functionality would you like to see in your phoniebox v3.x?

Integration with Smart Home solutions like Home Assistant via MQTT. Similar to how it is implemented in version 2.x

How do you envision the feature to work from a users perspective?

As the user I can configure the connection to my MQTT broker via the jukebox.yml. Then the phoniebox is connecting to the broker and starts broadcasting various status messages e.g. Playerstate, Volume ....
But It can also then be controlled via MQTT to allow for example via Home Assistant to mute the player.
The status of the connection to the broker should be easily visible in the webapp.

Further information that might help

The features should be on par with to how version 2.x has implemented plus potentially additional features that might be useful.

I am happy to build this functionality since I already contributed to the version 2.x mqtt solution previously and would like to migrate my two phonieboxes to version 3.x (no MQTT support is blocking this currently).
@s-martin s-martin added the future3 Relates to future3 development label Jan 31, 2023
@s-martin
Copy link
Collaborator

s-martin commented Jan 31, 2023 •
edited
Loading

MQTT is not yet implemented https://rpi-jukebox-rfid.readthedocs.io/en/latest/featurelist.html#feature-status

But pull requests and contributors are always welcome!

@pabera @ChisSoc

@pabera
Copy link
Collaborator

pabera commented Mar 16, 2023

Wonderful feature which could use a pull request :-)

@s-martin
Copy link
Collaborator

s-martin commented Dec 28, 2023 •
edited
Loading

For anyone interested in implementing this feature, here are some thoughts how this could be done:

https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/future3%2Fdevelop/src%2Fjukebox%2Fjukebox%2Fpublishing%2Fserver.py#L135-L142

@pabera pabera added this to the v3.6 milestone Mar 21, 2024
@pabera pabera modified the milestones: v3.6, v3.7 Apr 8, 2024
@c0un7-z3r0
Copy link
Contributor Author

More then a year later. I started working on this topic. Finally. Basic mqtt updates are working already now need to see which other values I need to map and how I implement the mqtt commands. Once this is done I will add some test and open up the PR.

But this is the first time I work with zeromq. Not sure if I followed the architecture and the ideas you linked to @s-martin . So any initial thoughts or quick feedback would be appreciated.

Here is the WIP implementation https://github.com/c0un7-z3r0/RPi-Jukebox-RFID/blob/future3/add-mqtt/src/jukebox/components/mqtt/__init__.py

@s-martin
Copy link
Collaborator

s-martin commented Jun 21, 2024 •
edited
Loading

Thanks for starting the work on this feature! 🎉

We will look into it.

@c0un7-z3r0 c0un7-z3r0 linked a pull request Aug 3, 2024 that will close this issue
Open
@s-martin s-martin linked a pull request Aug 3, 2024 that will close this issue
feat: add basic mqtt support #2412
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement future3 Relates to future3 development help wanted
Projects
None yet
Milestone
v3.7
Development

Successfully merging a pull request may close this issue.

feat: add basic mqtt support c0un7-z3r0/RPi-Jukebox-RFID
3 participants
@pabera @s-martin @c0un7-z3r0