Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds doc for default node identifier #2424

Closed
wants to merge 2 commits into from

Conversation

cosh
Copy link
Contributor

@cosh cosh commented Oct 22, 2024

Thank you for contributing to Azure Data Explorer documentation

Fill out these items before submitting your pull request:

If you are working internally at Microsoft:

  • Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

  • Who is your Docs team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

  • 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

  • 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

  • 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

  • 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

  • 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

  • After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
  • The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
  • Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the *main( branch or a release-branch).
  • From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

Copy link
Contributor

@cosh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 1f7852b:

✅ Validation status: passed

File Status Preview URL Details
data-explorer/kusto/query/make-graph-operator.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@ShannonLeavitt
Copy link
Contributor

Hi @cosh

Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.

After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.

Read about authors working in the public repo for more information.

If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform.

We'll close this PR. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants