From 2f98a8ed7f28dad44e3b3063dba0185a56e6fbba Mon Sep 17 00:00:00 2001
From: Meira Josephy <144697924+mjosephym@users.noreply.github.com>
Date: Tue, 6 Aug 2024 13:03:58 +0300
Subject: [PATCH 1/9] [Test] removed spaces
---
data-explorer/add-query-visualization.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/data-explorer/add-query-visualization.md b/data-explorer/add-query-visualization.md
index 746de1da06..cf57c9ad48 100644
--- a/data-explorer/add-query-visualization.md
+++ b/data-explorer/add-query-visualization.md
@@ -18,7 +18,7 @@ For a full list of available visuals, see [Visualization](kusto/query/render-ope
## Add a visual to a query
-1. [Run a query](web-ui-query-overview.md#write-and-run-queries) in the Azure Data Explorer web UI. For example, you can use the following query:
+1. [Run a query](web-ui-query-overview.md#write-and-run-queries) in the Azure Data Explorer web UI. For example, you can use the following query:
> [!div class="nextstepaction"]
> Run the query
@@ -53,12 +53,12 @@ If you've added a visual through the UI, you can change this visual by selecting
### Visual created in query
-If you've created a visual using the [render operator](kusto/query/render-operator.md), you can edit the visual by selecting **Visual** in the results grid.
+If you've created a visual using the [render operator](kusto/query/render-operator.md), you can edit the visual by selecting **Visual** in the results grid.
:::image type="content" source="media/add-query-visualization/change-rendered-visual.png" alt-text="Screenshot of rendered visual as a bar chart that has been changed to a column chart in the visual formatting pane in Azure Data Explorer web UI." lightbox="media/add-query-visualization/change-rendered-visual.png":::
> [!IMPORTANT]
-> Notice that the visual formatting pane has changed the visual representation, but has not modified the original query.
+> Notice that the visual formatting pane has changed the visual representation, but has not modified the original query.
## Pin to dashboard
From 0882cde3223bc417c4d360906b38c0dd5a4245bc Mon Sep 17 00:00:00 2001
From: andykop <165172502+AndyKop@users.noreply.github.com>
Date: Tue, 6 Aug 2024 14:44:49 +0300
Subject: [PATCH 2/9] [TEST] table pipe added
---
data-explorer/dashboard-parameters.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data-explorer/dashboard-parameters.md b/data-explorer/dashboard-parameters.md
index c385c23842..9ae5b65c39 100644
--- a/data-explorer/dashboard-parameters.md
+++ b/data-explorer/dashboard-parameters.md
@@ -57,7 +57,7 @@ In the **Add parameter** pane, configure the following properties:
|**Data type**|The data type of the parameter values.|
|**Show on pages**|Select the pages where this parameter will be displayed. The **Select all** option shows the parameter on all pages.|
|**Source**|The source of the parameter values:
- **Fixed values**: Manually introduced static filter values.
- **Query**: Dynamically introduced values using a KQL query.
|
-|**Default value**|The default value of the filter. The filter will start always with the default value upon initial rendering of the dashboard.
+|**Default value**|The default value of the filter. The filter will start always with the default value upon initial rendering of the dashboard.|
|**Add a "Select all" value**|Applicable only to single selection and multiple selection parameter types. Used to retrieve data for all the parameter values. This value should be built into the query to provide the functionality. For more examples of building such queries, see [Use the multiple-selection query-based parameter](#multiple-selection-fixed-values-parameters).|
## Manage parameters
From b79a43884407aeac76ea15a5f8a0036be32b01a7 Mon Sep 17 00:00:00 2001
From: andykop <165172502+AndyKop@users.noreply.github.com>
Date: Tue, 6 Aug 2024 14:53:39 +0300
Subject: [PATCH 3/9] [TEST] removed extra spaces
---
.../data-factory-command-activity.md | 38 +++++++++----------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/data-explorer/data-factory-command-activity.md b/data-explorer/data-factory-command-activity.md
index 938300977c..d3a4a5789c 100644
--- a/data-explorer/data-factory-command-activity.md
+++ b/data-explorer/data-factory-command-activity.md
@@ -21,7 +21,7 @@ ms.date: 09/13/2023
## Create a new pipeline
-1. Select the **Author** pencil tool.
+1. Select the **Author** pencil tool.
1. Create a new pipeline by selecting **+** and then select **Pipeline** from the drop-down.
![create new pipeline.](media/data-factory-command-activity/create-pipeline.png)
@@ -31,10 +31,10 @@ ms.date: 09/13/2023
A [lookup activity](/azure/data-factory/control-flow-lookup-activity) can retrieve a dataset from any Azure Data Factory-supported data sources. The output from Lookup activity can be used in a ForEach or other activity.
1. In the **Activities** pane, under **General**, select the **Lookup** activity. Drag and drop it into the main canvas on the right.
-
+
![select lookup activity.](media/data-factory-command-activity/select-activity.png)
-1. The canvas now contains the Lookup activity you created. Use the tabs below the canvas to change any relevant parameters. In **General**, rename the activity.
+1. The canvas now contains the Lookup activity you created. Use the tabs below the canvas to change any relevant parameters. In **General**, rename the activity.
![edit lookup activity.](media/data-factory-command-activity/edit-lookup-activity.png)
@@ -44,20 +44,20 @@ A [lookup activity](/azure/data-factory/control-flow-lookup-activity) can retrie
### Create an Azure Data Explorer dataset in lookup activity
1. In **Settings**, select your pre-created Azure Data Explorer **Source dataset**, or select **+ New** to create a new dataset.
-
+
![add dataset in lookup settings.](media/data-factory-command-activity/lookup-settings.png)
1. Select the **Azure Data Explorer (Kusto)** dataset from **New Dataset** window. Select **Continue** to add the new dataset.
- ![select new dataset.](media/data-factory-command-activity/select-new-dataset.png)
+ ![select new dataset.](media/data-factory-command-activity/select-new-dataset.png)
1. The new Azure Data Explorer dataset parameters are visible in **Settings**. To update the parameters, select **Edit**.
![lookup settings with Azure Data Explorer dataset.](media/data-factory-command-activity/lookup-settings-with-adx-dataset.png)
-1. The **AzureDataExplorerTable** new tab opens in the main canvas.
- * Select **General** and edit the dataset name.
- * Select **Connection** to edit the dataset properties.
+1. The **AzureDataExplorerTable** new tab opens in the main canvas.
+ * Select **General** and edit the dataset name.
+ * Select **Connection** to edit the dataset properties.
* Select the **Linked service** from the drop-down, or select **+ New** to create a new linked service.
![Edit Azure Data Explorer dataset properties.](media/data-factory-command-activity/adx-dataset-properties-edit-connections.png)
@@ -67,8 +67,8 @@ A [lookup activity](/azure/data-factory/control-flow-lookup-activity) can retrie
![ Azure Data Explorer new linked service.](media/data-factory-command-activity/adx-new-linked-service.png)
* Select **Name** for Azure Data Explorer linked service. Add **Description** if needed.
- * In **Connect via integration runtime**, change current settings, if needed.
- * In **Account selection method** select your cluster using one of two methods:
+ * In **Connect via integration runtime**, change current settings, if needed.
+ * In **Account selection method** select your cluster using one of two methods:
* Select the **From Azure subscription** radio button and select your **Azure subscription** account. Then, select your **Cluster**. Note the drop-down will only list clusters that belong to the user.
* Instead, select **Enter manually** radio button and enter your **Endpoint** (cluster URL).
* Specify the **Tenant**.
@@ -92,15 +92,15 @@ A [lookup activity](/azure/data-factory/control-flow-lookup-activity) can retrie
| summarize count() by Database
```
-1. Change the **Query timeout** or **No truncation** and **First row only** properties, as needed. In this flow, we keep the default **Query timeout** and uncheck the checkboxes.
+1. Change the **Query timeout** or **No truncation** and **First row only** properties, as needed. In this flow, we keep the default **Query timeout** and uncheck the checkboxes.
![Final settings of lookup activity.](media/data-factory-command-activity/lookup-activity-final-settings.png)
-## Create a For-Each activity
+## Create a For-Each activity
-The [For-Each](/azure/data-factory/control-flow-for-each-activity) activity is used to iterate over a collection and execute specified activities in a loop.
+The [For-Each](/azure/data-factory/control-flow-for-each-activity) activity is used to iterate over a collection and execute specified activities in a loop.
-1. Now you add a For-Each activity to the pipeline. This activity will process the data returned from the Lookup activity.
+1. Now you add a For-Each activity to the pipeline. This activity will process the data returned from the Lookup activity.
* In the **Activities** pane, under **Iteration & Conditionals**, select the **ForEach** activity and drag and drop it into the canvas.
* Draw a line between the output of the Lookup activity and the input of the ForEach activity in the canvas to connect them.
@@ -140,7 +140,7 @@ The [For-Each](/azure/data-factory/control-flow-for-each-activity) activity is u
The **Command** instructs Azure Data Explorer to export the results of a given query into a blob storage, in a compressed format. It runs asynchronously (using the async modifier).
The query addresses the database column of each row in the Lookup activity result. The **Command timeout** can be left unchanged.
- ![command activity.](media/data-factory-command-activity/command.png)
+ ![command activity.](media/data-factory-command-activity/command.png)
> [!NOTE]
> The command activity has the following limits:
@@ -156,7 +156,7 @@ The [For-Each](/azure/data-factory/control-flow-for-each-activity) activity is u
![azure data explorer command activity output.](media/data-factory-command-activity/command-activity-output.png)
-1. You can **Publish All** and then **Add trigger** to run the pipeline.
+1. You can **Publish All** and then **Add trigger** to run the pipeline.
## Management command outputs
@@ -164,7 +164,7 @@ The structure of the command activity output is detailed below. This output can
### Returned value of a non-async management command
-In a non-async management command, the structure of the returned value is similar to the structure of the Lookup activity result. The `count` field indicates the number of returned records. A fixed array field `value` contains a list of records.
+In a non-async management command, the structure of the returned value is similar to the structure of the Lookup activity result. The `count` field indicates the number of returned records. A fixed array field `value` contains a list of records.
```json
{
@@ -209,9 +209,9 @@ In an async management command, the activity polls the operations table behind t
}
]
}
-```
+```
## Related content
* [Copy data to Azure Data Explorer using Azure Data Factory](data-factory-load-data.md).
-* [Azure Data Factory template for bulk copy from database to Azure Data Explorer](data-factory-template.md).
\ No newline at end of file
+* [Azure Data Factory template for bulk copy from database to Azure Data Explorer](data-factory-template.md).
From cb582b7405f3c1b56005e8675a7095f43f43bf4f Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 15:24:23 +0300
Subject: [PATCH 4/9] Create bypass-codeowner-approval.yml
---
.../workflows/bypass-codeowner-approval.yml | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 .github/workflows/bypass-codeowner-approval.yml
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
new file mode 100644
index 0000000000..af4d7be494
--- /dev/null
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -0,0 +1,25 @@
+name: Bypass Code Owner Approval
+on:
+ pull_request:
+ types: [opened, synchronize, reopened]
+
+jobs:
+ bypass_approval:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Check if PR author is a code owner
+ id: check-author
+ run: |
+ TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
+ https://api.github.com/orgs/YOUR_ORG/teams/YOUR_TEAM/members)
+ if echo "$TEAM_MEMBERS" | grep -q "\"login\": \"${{ github.actor }}\""; then
+ echo "::set-output name=is_codeowner::true"
+ else
+ echo "::set-output name=is_codeowner::false"
+ fi
+
+ - name: Bypass approval if author is a code owner
+ if: steps.check-author.outputs.is_codeowner == 'true'
+ run: |
+ echo "Bypassing approval for code owner"
+ # Add your logic here to bypass approval
From 88fdf7e22dda2659107118ba27d43b1abfd50084 Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 16:13:10 +0300
Subject: [PATCH 5/9] Update actions
---
.github/workflows/bypass-codeowner-approval.yml | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
index af4d7be494..a4e8db563c 100644
--- a/.github/workflows/bypass-codeowner-approval.yml
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -10,8 +10,8 @@ jobs:
- name: Check if PR author is a code owner
id: check-author
run: |
- TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
- https://api.github.com/orgs/YOUR_ORG/teams/YOUR_TEAM/members)
+ TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.ACTIONS_TOKEN }}" \
+ https://api.github.com/orgs/MicrosoftDocs/teams/kusto-doc-writers/members)
if echo "$TEAM_MEMBERS" | grep -q "\"login\": \"${{ github.actor }}\""; then
echo "::set-output name=is_codeowner::true"
else
@@ -22,4 +22,7 @@ jobs:
if: steps.check-author.outputs.is_codeowner == 'true'
run: |
echo "Bypassing approval for code owner"
- # Add your logic here to bypass approval
+ curl -s -X POST -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
+ -H "Accept: application/vnd.github.v3+json" \
+ https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews \
+ -d '{"event":"APPROVE"}'
From 121d0f19705365a0b71b74921a45cb0d66b3bbe7 Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 16:56:58 +0300
Subject: [PATCH 6/9] Update actions
---
.github/workflows/bypass-codeowner-approval.yml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
index a4e8db563c..8ea45cccf0 100644
--- a/.github/workflows/bypass-codeowner-approval.yml
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -13,10 +13,13 @@ jobs:
TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.ACTIONS_TOKEN }}" \
https://api.github.com/orgs/MicrosoftDocs/teams/kusto-doc-writers/members)
if echo "$TEAM_MEMBERS" | grep -q "\"login\": \"${{ github.actor }}\""; then
- echo "::set-output name=is_codeowner::true"
+ DEBUG_IS_CODEOWNER=true
+ echo "is_codeowner=true" >> $GITHUB_ENV
else
- echo "::set-output name=is_codeowner::false"
+ DEBUG_IS_CODEOWNER=false
+ echo "is_codeowner=false" >> $GITHUB_ENV
fi
+ echo "::debug::is_codeowner=$DEBUG_IS_CODEOWNER -- Team members: $TEAM_MEMBERS"
- name: Bypass approval if author is a code owner
if: steps.check-author.outputs.is_codeowner == 'true'
From 38bb6a649c5961228721c84e750c47ab16a07621 Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 17:33:05 +0300
Subject: [PATCH 7/9] Update actions
---
.github/workflows/bypass-codeowner-approval.yml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
index 8ea45cccf0..33aaca36d2 100644
--- a/.github/workflows/bypass-codeowner-approval.yml
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -19,13 +19,15 @@ jobs:
DEBUG_IS_CODEOWNER=false
echo "is_codeowner=false" >> $GITHUB_ENV
fi
- echo "::debug::is_codeowner=$DEBUG_IS_CODEOWNER -- Team members: $TEAM_MEMBERS"
+ echo "::debug::Team members - $TEAM_MEMBERS"
+ echo "::debug::is_codeowner - $DEBUG_IS_CODEOWNER"
- name: Bypass approval if author is a code owner
+ id: bypass-approval
if: steps.check-author.outputs.is_codeowner == 'true'
run: |
echo "Bypassing approval for code owner"
- curl -s -X POST -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
+ curl -s -X POST -H "Authorization: token ${{ secrets.ACTIONS_TOKEN }}" \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews \
-d '{"event":"APPROVE"}'
From 945f3e33ba8acc8017f081574ff02eca587c2bed Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 19:16:42 +0300
Subject: [PATCH 8/9] Update actions
---
.github/workflows/bypass-codeowner-approval.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
index 33aaca36d2..b14d24a273 100644
--- a/.github/workflows/bypass-codeowner-approval.yml
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -10,7 +10,7 @@ jobs:
- name: Check if PR author is a code owner
id: check-author
run: |
- TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.ACTIONS_TOKEN }}" \
+ TEAM_MEMBERS=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
https://api.github.com/orgs/MicrosoftDocs/teams/kusto-doc-writers/members)
if echo "$TEAM_MEMBERS" | grep -q "\"login\": \"${{ github.actor }}\""; then
DEBUG_IS_CODEOWNER=true
@@ -27,7 +27,7 @@ jobs:
if: steps.check-author.outputs.is_codeowner == 'true'
run: |
echo "Bypassing approval for code owner"
- curl -s -X POST -H "Authorization: token ${{ secrets.ACTIONS_TOKEN }}" \
+ curl -s -X POST -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews \
-d '{"event":"APPROVE"}'
From d96caa414d623705ef4a39b3ebf875d9cd82d6d8 Mon Sep 17 00:00:00 2001
From: Shlomo Sagir <51323195+shsagir@users.noreply.github.com>
Date: Tue, 6 Aug 2024 19:17:53 +0300
Subject: [PATCH 9/9] Update actions
---
.github/workflows/bypass-codeowner-approval.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/bypass-codeowner-approval.yml b/.github/workflows/bypass-codeowner-approval.yml
index b14d24a273..59a9c83c31 100644
--- a/.github/workflows/bypass-codeowner-approval.yml
+++ b/.github/workflows/bypass-codeowner-approval.yml
@@ -19,8 +19,8 @@ jobs:
DEBUG_IS_CODEOWNER=false
echo "is_codeowner=false" >> $GITHUB_ENV
fi
- echo "::debug::Team members - $TEAM_MEMBERS"
- echo "::debug::is_codeowner - $DEBUG_IS_CODEOWNER"
+ echo "::debug::Team members -- $TEAM_MEMBERS"
+ echo "::debug::is_codeowner -- $DEBUG_IS_CODEOWNER"
- name: Bypass approval if author is a code owner
id: bypass-approval