Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading visibility_timeout, Required vs optional parameters, updates needed! #1552

Open
Vignesh-Microsoft opened this issue May 11, 2022 · 1 comment

Comments

@Vignesh-Microsoft
Copy link

I see this correction on the sdk git but not on docs. Please update as needed.

https://docs.microsoft.com/en-us/python/api/azure-storage-queue/azure.storage.queue.queueclient?view=azure-python#azure-storage-queue-queueclient-receive-message

The PR and commit:

#1548

25f6410

Also, for update_message, pop_receipt and content don't need to be a required parameter. One place it says optional but another it says required. Details below:

image

WHY is it optional, because

  1. pop_receipt is already part of the message object. pop_receipt is only required if message object is not there like in case of cli and powershell.

  2. if we are issuing an update call for visibility_timeout alone, we do not need content as required parameter so it is optional.

Same for delete_message

image

Commit:

e9d4668

Please review and approve if it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants