Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad interpretation of certains lines #6

Open
Katosy opened this issue Jul 23, 2024 · 2 comments · May be fixed by #7
Open

Bad interpretation of certains lines #6

Katosy opened this issue Jul 23, 2024 · 2 comments · May be fixed by #7
Assignees
@pirmink

Comments

@Katosy
Copy link

Katosy commented Jul 23, 2024

the line :
character*(*) char2
get transformed into
character(len=2) :: char2
when it shoud be
character(len=*) :: char2
this is because the subroutine check_character search for the first digit when lstar is true
@Katosy
Copy link
Author

Katosy commented Jul 23, 2024 •
edited
Loading

in check_character I think that just inverting the step works
so check before for *(*) and if nothing is found just take the first digit of the line as the length

@pirmink pirmink self-assigned this Jul 23, 2024
@pirmink pirmink linked a pull request Jul 23, 2024 that will close this issue
Fix conversion of assumed length character dummy argument. #7
Draft
@Katosy
Copy link
Author

Katosy commented Jul 24, 2024

After futher testing, swapping still doesn't work for weird lines like
character*128 :: var1, var2*(*)

the fact that stringpattern search anywhere in the line is the main issue
searching for the next char after the star would probably be best.

This tools is really amazing and thanks for reacting !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirmink pirmink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conversion of assumed length character dummy argument. MeteoSwiss/ffixed2free
2 participants
@pirmink @Katosy