Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: calling wallet_requestPermissions providing an address is ignored #20237

Closed
shanejonas opened this issue Jul 27, 2023 · 5 comments
Closed
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-wallet-api-platform type-bug

Comments

@shanejonas
Copy link
Contributor

Describe the bug

  1. wallet_requestPermission is not respecting the caveats in the permissions approval screen that pops up. the approval UI screen should show the the addresses passed in pre selected the UI.

Steps to reproduce

  1. requestPermissions with an account that is not currently selected:
await window.ethereum.request({
  "method": "wallet_requestPermissions",
  "params": [
    {
      "eth_accounts": {
        "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266": true
      }
    }
  ]
});

or

         await window.ethereum.request({
          method: 'wallet_requestPermissions',
          params: [
            {
              eth_accounts: {
                "caveats": [
                  {
                    "type": "restrictReturnedAccounts",
                    "value": [
                      "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266"
                     ]
                  }
                ]
              },
            },
          ],
        })
  1. see that it is not pre selected in the approval UI

Error messages or log output

No response

Version

10.34.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

@vandan
Copy link

vandan commented Oct 20, 2023

You have to be on a different account to reproduce this issue.

@vandan vandan added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Oct 20, 2023
@vandan
Copy link

vandan commented Oct 20, 2023

May relate to this MIP: MetaMask/metamask-improvement-proposals#24

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jan 18, 2024
@vandan vandan removed the stale issues and PRs marked as stale label Jan 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Apr 21, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-wallet-api-platform type-bug
Projects
Archived in project
Development

No branches or pull requests

3 participants