Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag methods that have confirmation dialogs associated with them #205

Open
BelfordZ opened this issue Mar 27, 2024 · 1 comment
Open

Tag methods that have confirmation dialogs associated with them #205

BelfordZ opened this issue Mar 27, 2024 · 1 comment
Labels
team-wallet-api-platform

Comments

@BelfordZ
Copy link
Contributor

Many times we find ourselves wanting to know which set of methods will require a confirmation method. As such, we should just add a tag to make it really obivous and create a single source of truth for this expectation.
@BelfordZ
Copy link
Contributor Author

example: https://github.com/MetaMask/core/pull/4066/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shanejonas @BelfordZ