New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc_wrap.py is failing due to use of string operation on bytes object #84

Open

rohit-mundra opened this issue Mar 5, 2024 · 0 comments · May be fixed by #85

rohit-mundra commented Mar 5, 2024

tc_wrap.py is using Popen to execute instructions and the output is in bytes, as no encoding being defined in the argument to Popen.

As the output is in bytes, the regex and split on bytes will fail, this requires the output must be decoded before consumption.

https://github.com/Mellanox/mlnx-tools/blob/mlnx_ofed/python/tc_wrap.py#L153

https://github.com/Mellanox/mlnx-tools/blob/mlnx_ofed/python/tc_wrap.py#L56

rohit-mundra linked a pull request

that will close this issue

Decode bytes before running string operations on the same #85

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment