Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-Checked Locking #19

Open
QiAnXinCodeSafe opened this issue May 6, 2020 · 0 comments
Open

Double-Checked Locking #19

QiAnXinCodeSafe opened this issue May 6, 2020 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

if (zkClient == null) {
synchronized (ZookeeperManager.class) {
zkClient = zkClients.get(address);
if (zkClient == null) {
zkClient = new ZookeeperClient(address);
zkClients.putIfAbsent(address, zkClient);

Double-Checked Locking is widely cited and used as an efficient method for implementing lazy initialization in a multithreaded environment.
Unfortunately, it will not work reliably in a platform independent way when implemented in Java, without additional synchronization.
declares the zkClient field volatile offers a much more elegant solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant