pbcore_2 - maps General_Format to instantiationStandard https://githu…

[kieranjol]

…b.com//issues/786

Hey, I tried building mediainfolib and mediainfo on osx and I couldn't see the changes appear - possibly i'm doing something wrong with the build or these changes are not enough.

Anyhow, does this look like it could work?
#786

[JeromeMartinez]

Tested, and I have the expected output:

	<instantiationDigital>audio/vnd.wave</instantiationDigital>
	<instantiationStandard>Wave</instantiationStandard>
	<instantiationLocation>blabla.wav</instantiationLocation>

Now wondering what to do with the old "Format" part, duplicate content but if we remove the old "format" part it may break some automated parsings.

On hold until Dave reviews it.

[kieranjol]

Hey, I finally got it to build (make clean is my friend) - and I also get the expected output. I think Standard is in the correct order of PBCore elements as well. I was thinking about the old "Format" part as well ,but I'm thinking it could break old parsings. I think there is no harm in leaving it in as an annotation.

[kieranjol]

If it helps, here's three outputs with my patch:
https://gist.github.com/kieranjol/6572e72159d1c95a05c40b30e3783b9a

Matroska, QuickTime, Mpeg-4

        <instantiationDigital>video/x-matroska</instantiationDigital>
        <instantiationStandard>Matroska</instantiationStandard>

	<instantiationDigital>video/quicktime</instantiationDigital>
	<instantiationStandard>QuickTime</instantiationStandard>

	<instantiationDigital>video/mp4</instantiationDigital>
	<instantiationStandard>MPEG-4</instantiationStandard>

[JeromeMartinez]

@kieranjol maybe flagging the duplicate content in the source code, e.g. a comment "//TODO remove this line at next version bump" in the corresponding source code line? So we can track duplicate content and clean up the output when we can.

[kieranjol]

Sounds good to me - I'm just having difficulty finding the specific line of code that is pulling that Format annotation... I can see the instantiationAnnotations section in the code, but I'm not seeing that specific element - I see Format/URL and Format_Commercial..

[JeromeMartinez]

A new public release is expected next week. @dericed something you want to change in this PR?

[kieranjol]

Ping

[kieranjol]

@dericed ping.. just wondering if this looks OK, can it be merged or do you want to wait until you've done some refactoring as mentioned in #786?

[dericed]

I have some notes on this field from a meeting with WGBH but I’m afk today.

[kieranjol]

Ah cool, I look forward to hearing more. Enjoy the AFK, i'm going to do the same.