Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the Encoded Library information stored in a tag (fix #1267) #1268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugenesvk
Copy link
Contributor

This fixes #1267

@eugenesvk
Copy link
Contributor Author

eugenesvk commented May 25, 2020

I see that this Travis CI job failed with ../.libs/libmediainfo.so: undefined reference to 'MediaInfoLib::Encoded_Library_Tag' error and with these options seemingly different from a successfull build

-DMEDIAINFO_ALL_NO -DMEDIAINFO_MIXML_YES"
$ export RUN_TESTS="mixml"

Not sure what these are and how I can turn them on on my side to test (I was only using the MSVC2019 project), so will wait for your input

@JeromeMartinez
Copy link
Member

@eugenesvk thanks for the PR. I don't want to have more source file for this unique item, I'll adapt your patch proposal.

@eugenesvk
Copy link
Contributor Author

That's totally fine, it was just the simplest way I found to fix it (I was also thinking of disabling the split into name/version as at first glance it only seemed to be useful to remove a "-" in "x265 - ..." :), but then it was more complicated to trying to figure out all of its uses

(cherry picked from branch Patch-EncLib@Tag: commit 4c4ab2f)
@eugenesvk eugenesvk reopened this Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retain the Encoded Library information stored in a tag
2 participants