Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Ensure correct installers are used for each system #987

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Dec 5, 2024

Since there is now ARM64.

@JeromeMartinez
Copy link
Member

For coherency, not something similar for i386 (test on i386 only or ARM64 on Win10)?

Prevent i386 installer from being used on systems that are supported by other installers.
@cjee21 cjee21 changed the title Windows GUI: Ensure x64 installer only runs on x86-64 Windows GUI: Ensure correct installers are used for each system Dec 6, 2024
@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 6, 2024

For combined installer will be in separate PR along with adding ARM64 handling after making sure ARM64 works fine.

@JeromeMartinez
Copy link
Member

after making sure ARM64 works fine.

Exactly.

@JeromeMartinez JeromeMartinez merged commit 70015ea into MediaArea:master Dec 6, 2024
3 checks passed
@cjee21 cjee21 deleted the NSIS branch December 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants