-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI output includes inconsequential failures for "OR" policy rules #786
Comments
True that showing failed checks while it is a pass due to the upper "or" is not good and it is misleading. |
Is this a development that can happen? Being above to have this enhancement would change and greatly simplify how we write our policies in addition to simplifying our workflows. |
Yes, we are interested in that. Actually it is a collateral damage of a feature we implemented some time ago (different level of error: error/warning/info), before this development the behavior was the one you expect. |
Can you share the xml output for a failing file? |
On can skip all inconsequential pass/fails by piping into xmlstarlet, such as:
For example with the file that @bravoalphatango linked to the output is:
|
The CLI output for MediaConch seems to be mixing real and inconsequential failures for "OR" policy rules.
For example, I have a policy that can accept MKVs that are either NTSC or PAL with 2 channels of audio. My files are NTSC and all of them have 4 channels of audio expect for one. So all of my files will fail except for one but the rule they fail should not be the "OR" policy related to regional encoding. The audio channel rule should be the only rule that actually fails. This is represented in the GUI correctly:
However, when I use the CLI the output will list all of the PAL characteristics the files did not pass even though the file passes this rule. Here is a video and a screenshot:
(https://drive.google.com/file/d/1lmFjGJ8x15898yZJLCaw6izrhdBDYJaL/view?usp=sharing)
Here is the policy I am using.
Is there a way to work around this that I have overlooked? If not, is it possible to create a flag that abbreviates this output? It is not realistic to use the GUI with the volume of files we want to be QCing.
The text was updated successfully, but these errors were encountered: