-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't run skeleton template on a roborio 1 #126
Comments
We're experimenting with some different GC options for the AdvantageKit templates this year, with the goal of improving performance on the RIO 1 and 2. After some further testing, there area some specific optimizations that we will probably disable by default because they can cause these types of issues on the RIO 1 (despite improving performance on the RIO 2). Try updating frcJava(getArtifactTypeClass('FRCJavaArtifact')) {
jvmArgs.add("-XX:GCTimeRatio=5")
jvmArgs.add("-XX:+UseSerialGC")
jvmArgs.add("-XX:MaxGCPauseMillis=50")
} This is closer to WPILib's default settings, and seems to work well on the RIO 1 in my testing. We will probably switch the default GC in the templates to this configuration, with documentation for additional options RIO 2 users may want to enable. |
I've been experiencing the same issue on our RIO 1. With the specified changes to the
|
The updates I posted are not in the posted skeleton template. The lines I posted should be the only configuration under |
Crash on RIO 1 because of AK25's aggressive garbage collection, which works well on the RIO 2. This commit implements the changes suggested in this issue on GitHub: Mechanical-Advantage/AdvantageKit#126 modified: build.gradle
Describe the bug
When trying to run the basic skeleton template on a roborio 1 you get an error saying there is insufficient memory
To Reproduce
Open the skeleton template from v4.0.0-beta-1 release.
Build the project and deploy to a roborio 1.
Expected behavior
The skeleton template should not cause memory problems.
Screenshots
Version (required):
The text was updated successfully, but these errors were encountered: