Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program fails to download artists with special characters + Program halts if a tag is invalid. #118

Open
UpscaleAnon opened this issue Jun 4, 2023 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@UpscaleAnon
Copy link

UpscaleAnon commented Jun 4, 2023

Issue 1:

Describe the bug
E621 Downloader fails to download artists with special characters like the artist "緘黙さん"
Also, why is the program made in such a way that it closes without giving ANY errors? A program should never auto close unless you specifically tell it to do so yourself. Even when it successfully downloads stuff, I'd rather have it not auto close, so I know it actually finished.

To Reproduce
Put "緘黙さん" in artist tag
Run the program
It auto closes with no errors or anything

Expected behavior
It should download

Screenshots
There's no error or anything to screenshot, I even used OBS to record it to see if anything appears last frame, but it did not.

Desktop (please complete the following information):
Windows 10 Home
22H2

Issue 2:

Describe the bug
E621 Downloader will come to a complete stop if you happen to have an artist tag that has a typo or doesn't exist, which is really annoying if you set it to for example download a few hundred artists over night just to see it actually did nothing.

To Reproduce
Put a tag with a typo in artist tag
Run the program
It stops

Expected behavior
It should try to download it, but if it fails, it should write a log file or something and then move onto next tag.

Screenshots
image

@UpscaleAnon UpscaleAnon added the Bug Something isn't working label Jun 4, 2023
@UpscaleAnon
Copy link
Author

UpscaleAnon commented Jun 4, 2023

Update: Issue 1 also happens if you happen to try and put a non artist tag as artist, like for example I had "zaush-una" entered and that caused a problem.
It would be really nice if it atleast let me know which tag is being problematic, especially when you have a list of thousands of artists.

@UpscaleAnon
Copy link
Author

Update 2: Seems like issue 1 and 2 have some similarities, like issue 1 happens with english letters too, but if an artist like for example trunchbull or zaush-una change their name on e621 so they have a different tag, the program will auto close.
I have no idea why it sometimes decides to just auto close (like with zaush-una and trunchbull) and sometimes actually tell you that a tag is invalid (like with dewclawpaw). Seems like most of the times, it will choose to auto close rather than tell you that the tag is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants