Can't Craft realistic torches

[HyperCodec]

The realistic torches won't craft, and only the normal torch recipe works. Maybe you could simply modify the vanilla torch instead of making a new item?

[voxelli]

I believe this has to do with realistictorches:unlit_torch not being properly registered. I don't have my development env set up, but it looks like the problem is a simple typo:

RealisticTorches/src/main/java/com/chaosthedude/realistictorches/items/RealisticTorchesItems.java

Line 36 in 9e1e704

new UnlitTorchItem(new Item.Properties()).setRegistryName(new ResourceLocation(RealisticTorches.MODID, UnlitTorchItem.NAME)),

There is an extra ).

[Felix-FTW]

The mod was working fine until I made a copy of my world, now I can't craft unlit torches

[HyperCodec]

The mod was working fine until I made a copy of my world, now I can't craft unlit torches

Do you know if this is fixed yet?

[HyperCodec]

This issue has been open for a year

[Felix-FTW]

yeah im pretty sure the mod is abandoned, it hasnt been updated past 1.16 i can probably get a guy to update it in the future if you have the money, look up arcane studios on discord, they have mod devs on there in the meantime, look at the code i put in the comments or check out that "Restric Recipes" mod

…

On Sun, Aug 14, 2022, 3:25 PM HyperCodec ***@***.***> wrote: This issue has been open for a year — Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVYIG3DF3F27WICFNA3OXJTVZFW4TANCNFSM46S3OXIA> . You are receiving this because you commented.Message ID: ***@***.***>

[HyperCodec]

yeah im pretty sure the mod is abandoned, it hasnt been updated past 1.16 i can probably get a guy to update it in the future if you have the money, look up arcane studios on discord, they have mod devs on there in the meantime, look at the code i put in the comments or check out that "Restric Recipes" mod
…

I could probably update the mod myself — it can't be that hard — rather than making someone else do it. The problem I see here is, if this is truly abandoned, no one will be there to accept a pull request.

[MattCzyr]

I could probably update the mod myself — it can't be that hard — rather than making someone else do it. The problem I see here is, if this is truly abandoned, no one will be there to accept a pull request.

I'm still around and able to accept the PR if someone wants to update this mod. I just haven't had the time to do it myself as I've been prioritizing my other mods for quite a while.

[Felix-FTW]

You should put what you just said in the description of the mod so people know what's up

…

On 10/11/22, Matt Czyr ***@***.***> wrote: > I could probably update the mod myself — it can't be _that_ hard — rather > than making someone else do it. The problem I see here is, if this is > truly abandoned, no one will be there to accept a pull request. I'm still around and able to accept the PR if someone wants to update this mod. I just haven't had the time to do it myself as I've been prioritizing my other mods for quite a while. -- Reply to this email directly or view it on GitHub: #44 (comment) You are receiving this because you commented. Message ID: ***@***.***>

[HyperCodec]

I believe this has to do with realistictorches:unlit_torch not being properly registered. I don't have my development env set up, but it looks like the problem is a simple typo:

RealisticTorches/src/main/java/com/chaosthedude/realistictorches/items/RealisticTorchesItems.java

Line 36 in 9e1e704

new UnlitTorchItem(new Item.Properties()).setRegistryName(new ResourceLocation(RealisticTorches.MODID, UnlitTorchItem.NAME)),

There is an extra ).

I don't see how there is an extra ). Looks the same as the rest.

[MattCzyr]

I've got some time to come back to this mod, and I looked into this issue. I wasn't able to recreate it myself (in my testing, unlit torches can be crafted as intended), but I have an idea of what might be causing it for others. If either of you are still facing this issue, try this file and see if it persists:

https://www.dropbox.com/s/6lkoymjstb5hpu5/RealisticTorches-1.16.5-3.1.3-beta.jar?dl=0

Note, I also updated to the latest Forge version for 1.16.5, so make sure you're using the latest version.

[HyperCodec]

I've got some time to come back to this mod, and I looked into this issue. I wasn't able to recreate it myself (in my testing, unlit torches can be crafted as intended), but I have an idea of what might be causing it for others. If either of you are still facing this issue, try this file and see if it persists:

https://www.dropbox.com/s/6lkoymjstb5hpu5/RealisticTorches-1.16.5-3.1.3-beta.jar?dl=0

Note, I also updated to the latest Forge version for 1.16.5, so make sure you're using the latest version.

I'll go find out what version and such I am using and get back to you (should be on Monday bc busy tomorrow)