Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name of "TERMINATED" state #101

Open
computron opened this issue Mar 29, 2024 · 1 comment
Open

name of "TERMINATED" state #101

computron opened this issue Mar 29, 2024 · 1 comment

Comments

@computron
Copy link
Collaborator

The name "TERMINATED" may be confusing for some users since termination often means user-termination or something abnormal happened.

Other possible terms could be:

  • CONCLUDED --> this indicates more normal ending to execution. Bad part is that it is somewhat synonymous with completed so the difference may not be clear.
  • EXECUTED --> this is more clearly delineated from completed, but executed may imply the job has begun execution but not completed execution

But overall I think either of these options is better than TERMINATED

@gpetretto
Copy link
Contributor

We indeed had some discussions when deciding the state names, trying to avoid ambiguities. I think that indeed CONCLUDED is too similar to COMPLETED.

To make it more explicitly we can also consider something like REMOTE_COMPLETED (or REMOTE_EXECUTED/REMOTE_CONCLUDED), similar to the REMOTE_ERROR. But this can also be confusing and too verbose.

I think that overall I like EXECUTED more.

Once the choice is made, the change should be easy to perform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants