Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partial data format to Optimade python tools. #1738

Open
3 of 7 tasks
JPBergsma opened this issue Aug 4, 2023 · 0 comments
Open
3 of 7 tasks

Add support for partial data format to Optimade python tools. #1738

JPBergsma opened this issue Aug 4, 2023 · 0 comments
Assignees
Milestone

Comments

@JPBergsma
Copy link
Contributor

JPBergsma commented Aug 4, 2023

After the last optimade workshop, the option to return data in parts was added to the OPTIMADE specification. OPTIMADE PR#467
With this issue, I would like to keep track of the different steps needed to implement this in the optimade-python-tools.

  • Create a pydantic model of the partial data response format.
  • Add code to convert python object to appropriate jsonlines response.
  • Add validators
  • Add unit tests for validator model and jsonlines response generator.
  • Add example data
  • Add code to recognize a property should be returned as partial data and correctly split up data in this case.
  • Add/Update integration tests

Questions ?

It would seem logical to store data/files in Grid FS of MongoDB. Do we want to enable this by default or make it optional ?

@JPBergsma JPBergsma added this to the OPTIMADE v1.2 milestone Aug 4, 2023
@JPBergsma JPBergsma self-assigned this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant