Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wrong outline border on ComboBox #3625

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix for wrong outline border on ComboBox #3625

merged 2 commits into from
Jul 9, 2024

Conversation

nicolaihenriksen
Copy link
Contributor

@nicolaihenriksen nicolaihenriksen commented Jul 5, 2024 •
edited
Loading

Fixes #3623

Added a test to reproduce the issue, and then fixed the issue by only conditionally modifying the OuterBorder.BorderThickness

ComboBoxFix

@nicolaihenriksen nicolaihenriksen added this to the 5.2.0 milestone Jul 5, 2024
@MichelMichels MichelMichels merged commit fe81676 into master Jul 9, 2024
2 checks passed
@MichelMichels MichelMichels deleted the fix3623 branch July 9, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelMichels MichelMichels MichelMichels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

ComboBox all borders visible when selected
2 participants
@nicolaihenriksen @MichelMichels