Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial message selection #597

Open
therealryan opened this issue Oct 25, 2023 · 0 comments
Open

Fix initial message selection #597

therealryan opened this issue Oct 25, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Collaborator

therealryan commented Oct 25, 2023 •
edited
Loading

The detail page is intended to show the most interesting message by default, but I've just noticed it's not working correctly: it will always try to show actual data even when there is none to be had and we'd be better off just looking at the expected. This is what we get for not having unit test coverage (see #232)

We should fix that.
@therealryan therealryan added bug Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@therealryan