Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index tag summary order #566

Open
therealryan opened this issue Oct 5, 2023 · 0 comments
Open

Index tag summary order #566

therealryan opened this issue Oct 5, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Collaborator

therealryan commented Oct 5, 2023

The tag summary display on the report index can display tags in two orders:

  • By tag popularity
  • By tag name

There's a slight oddness in this behaviour that you can see if you expand the tag summary in the example report - in the first mode histogram and PASS both have 100% popularity, so they're displayed together in that order, histogram before PASS
When we click the button to use lexicographic mode PASS comes before histogram, the opposite order.

This is how the sorting works. I guess there's a difference in the order that comes from Array.sort and String.localeCompare.

We should resolve that difference so that alphabetical order is consistent. It might be as simple as using the optional parameter to Array.sort to invoke localeCompare.

@therealryan therealryan added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant