Adding support for netstandard2.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowing/re-throwing OperationCancelledExceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, excellent library, thanks so much for making this available. You are miles ahead of any other C# VNC library out there and the integration work necessary to drop this into EasyConnect was straightforward and well designed.
This pull request does a few things:
Span-based API shims necessary for this aren't quite as efficient as their .NET Core counterparts, but they still useArrayPools to reduce allocations and perform perfectly well in my testing.ClientCutTextmessage type. Figured I would take care of this while I was in there messing about.CloseAsync()no longer throw uncaught exceptions when winding down the message threads. I made a few changes not to throw exceptions when the message thread workers detect cancellation and to to swallowOperationCancelledException, but if there is a better way to close a connection (while not exiting the entire application), feel free to let me know.Once again, thanks for all of your hard work on this library!