Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theming support #9

Open
fbanning opened this issue Jan 14, 2022 · 1 comment
Open

Add theming support #9

fbanning opened this issue Jan 14, 2022 · 1 comment
Labels
enhancement New feature or request theming Themes, colours, waytypes, etc.

Comments

@fbanning
Copy link
Member

fbanning commented Jan 14, 2022

Yeah, sorry I wasn't clear. It may be convenient to allow the user to pass a dictionary to osmplot! (or to propagate keyword arguments) so that the user can decide the color of the street types instead of the individual edges.
Originally posted by @Datseris in #8 (comment)

We have a pretty basic default theme in src/defaults. In default_consts.jl we for example define some dictionaries for colours, widths, and styles of edges depending on their way type ("motorway", "pedestrian", ...). These attributes are then used in defaults.jl for construction of the related edge attributes.

It would be very nice to implement some kind of basic theming support for users to change the colourscheme, widths, etc.
There might be two possible ways to do this:

  • Stick to current approach. Users can provide dictionaries of which values to change with fallbacks to default theme. This is easy to do with the current way to theme the plot and can be done as a first step.
  • Completely switch to using a Makie theme so that users can use Makie.set_theme! or Makie.with_theme. This is a more fundamental change and will require some research into Makie themes. I'm not sure if it provides all the detailed layers of theming that we require.
@fbanning fbanning added the enhancement New feature or request label Jan 14, 2022
@fbanning fbanning changed the title **Theming support** Add theming support Jan 19, 2022
@fbanning fbanning added the theming Themes, colours, waytypes, etc. label May 13, 2022
@fbanning
Copy link
Member Author

Implementing MapCSS support would make me happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request theming Themes, colours, waytypes, etc.
Projects
None yet
Development

No branches or pull requests

1 participant