Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to limits keyword in image? #4580

Open
dlfivefifty opened this issue Nov 10, 2024 · 3 comments
Open

What happened to limits keyword in image? #4580

dlfivefifty opened this issue Nov 10, 2024 · 3 comments

Comments

@dlfivefifty
Copy link
Contributor

There seems to no longer be a keyword named limits for specifying the bounding box of an image. How would one do this now?

I'm trying to update ComplexPhasePortrait.jl which uses this:

https://github.com/JuliaHolomorphic/ComplexPhasePortrait.jl/blob/master/ext/ComplexPhasePortraitMakieExt.jl

@SimonDanisch
Copy link
Member

Image never had a limits argument as far as I know...
My theory is that this was never working and simply got ignored and now we check for invalid keyword arguments

@dlfivefifty
Copy link
Contributor Author

Hmm it's possible you are right... but then how do you specify the bounding box for an image? In ComplexPhasePortrait.jl I want to plot a function on top of an image and have the axes be consistent

@SimonDanisch
Copy link
Member

You mean the size of the image?
It should be the x and y arguments: image((0, 1), (-5, 5), image_data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants