Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update GeometryOps compat #286

Closed
juliasloan25 opened this issue Nov 11, 2024 · 2 comments
Closed

bug: update GeometryOps compat #286

juliasloan25 opened this issue Nov 11, 2024 · 2 comments

Comments

@juliasloan25
Copy link

We've been seeing a few failures in downstream CliMA packages today (e.g. ClimaCoupler.jl GHA), which I believe is due to the following compat issues:

ExactPredicates was added to GeometryOps.jl in v0.1.6. GeoMakie.jl started using this feature in their release 0.7.6 earlier today, but didn't update the GeometryOps compat so it's still at v0.1.4. To maintain compat correctness, it should have been updated to 0.1.6 here.

I would open a PR to make the change myself, but it seems I don't have access rights to this repo. Would it be possible to make another patch release including this fix?

@juliasloan25 juliasloan25 changed the title update GeometryOps compat bug: update GeometryOps compat Nov 11, 2024
@juliasloan25
Copy link
Author

cc @asinghvi17

@asinghvi17
Copy link
Member

Thanks for the ping, forgot that we haven't done many releases of GeometryOps since ExactPredicates 😅.

New release v0.7.8 is out with bumped compatibility. But I do wonder what is keeping GeometryOps versions low on that CI?

We should probably have downgrade CI here as well. I'll add the script but may not have much time to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants