Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ax.finallimits[] not updated after calling limits!(ax, ...) #202

Closed
Zetison opened this issue Feb 10, 2024 · 1 comment
Closed

ax.finallimits[] not updated after calling limits!(ax, ...) #202

Zetison opened this issue Feb 10, 2024 · 1 comment

Comments

@Zetison
Copy link

Zetison commented Feb 10, 2024

A bug for v0.6.1 can be reproduced by

using GLMakie, GeoMakie; fig = Figure(); layout = fig[1,1] = GridLayout(); ax = GeoMakie.GeoAxis(layout[1,1], source="+proj=merc", dest="+proj=merc"); text!(ax,0.0,0.0,text="test"); limits!(ax,[-1.0, 2.5],[-2.0, 2.0]); println(ax.finallimits[].widths); display(fig)

which returns [3.499999729683623e-5, 3.9999998989515007e-5] instead of [3.5, 4.0] (for some reason a multiplication of a factor 1e-5 has occured). The same issue for ax.finallimits[].origin

@asinghvi17
Copy link
Member

#207 should fix this. That was expected behaviour earlier, the reason is that Makie used to run only on Float32, so we rescaled projections by 100_000 so that there was still enough float precision to do things. With #207 all computations are in Float64 which is substantially better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants