Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug adding text to GridLayout introduced in v0.6 #201

Closed
Zetison opened this issue Feb 8, 2024 · 4 comments
Closed

Bug adding text to GridLayout introduced in v0.6 #201

Zetison opened this issue Feb 8, 2024 · 4 comments
Labels
Makie An issue in base Makie

Comments

@Zetison
Copy link

Zetison commented Feb 8, 2024

A bug introduced in v0.6 (and not fixed in v0.6.1) can be reproduced by
using GLMakie, GeoMakie; fig = Figure(); layout = fig[1,1] = GridLayout(); ax = GeoMakie.GeoAxis(layout[1,1]); text!(ax, 0.0, 0.0, text = "test"); display(fig)
with error message
ERROR: MethodError: no method matching point_iterator(::MakieCore.Text{Tuple{Vector{Makie.GlyphCollection}}})

@asinghvi17
Copy link
Member

This is a Makie issue unfortunately - that particular method wasn't implemented there. I can monkeypatch it on master but would probably open a PR to fix it there...

@asinghvi17 asinghvi17 added the Makie An issue in base Makie label Feb 8, 2024
@asinghvi17
Copy link
Member

asinghvi17 commented Feb 8, 2024

For now, you can simply define:

Makie.point_iterator(::Makie.MakieCore.Text{Tuple{Vector{Makie.GlyphCollection}}}) = Point2f[]

which worked for me (temporarily, of course, since the ideal fix would be to get the text's position)

@apriljunge
Copy link

Just in case someone has the same problem:
This fixes issues with brackets too

@asinghvi17
Copy link
Member

asinghvi17 commented Jun 6, 2024

Looks fixed to me after #207 and Makie v0.21, feel free to reopen if you still encounter this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Makie An issue in base Makie
Projects
None yet
Development

No branches or pull requests

3 participants