Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only the first <Impression> element is fired when playing the ad #144

Open
carolshark opened this issue Feb 14, 2019 · 1 comment
Open

Only the first <Impression> element is fired when playing the ad #144

carolshark opened this issue Feb 14, 2019 · 1 comment

Comments

@carolshark
Copy link

According to IAB documentation, multiple Impression tags can be added to an ad. Currently, only the first impression is triggered. Seems to be related to:

mol-video-ad-sdk/src/tracker/trackLinearEvent.js

Line 67 in 17fbd64

[impression]: createVastEventTracker(getImpressionUri),

The selector should return multiple impression elements.
@shell1986
Copy link

I have the same problem.
Please correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carolshark @shell1986