Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(analysis): Add --large merge - merge multiple project files in a divided cc.json (#3743) #3841

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Dec 2, 2024

PR to Merge multiple projects files into one fat .cc.json

Closes: #3743
Closes: #3828

Description

  • add --large flag to the MergeFilter ccsh merge --large ...
  • merges all given projects into a cc.json file, but instead of bein g merged together, they are put into subfolders
  • subfolder names are defined by the dot-prefix of the input file e.g. myProj.cc.json -> root/myProj/*
  • updates edges and blacklist attributes to those new paths
  • add -o option to mimo, to specify output folder

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@phanlezz phanlezz force-pushed the feature/3743/mergefilter-merge-multiple-into-large branch from 955dc14 to 86960be Compare December 3, 2024 13:34
@phanlezz phanlezz force-pushed the feature/3743/mergefilter-merge-multiple-into-large branch from 86960be to 53abd5d Compare December 5, 2024 08:22
@ChristianHuehn
Copy link
Collaborator

Functionality is fine for me 👍 @IhsenBouallegue please do a code review

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nitpicks

@phanlezz phanlezz enabled auto-merge (rebase) December 5, 2024 13:05
Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

@phanlezz phanlezz merged commit 9920af9 into main Dec 5, 2024
8 checks passed
@phanlezz phanlezz deleted the feature/3743/mergefilter-merge-multiple-into-large branch December 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add output file option to Analysis MergeFilter MIMO Merge multiple projects files into one large .cc.json
3 participants