-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(analysis): Add --large
merge - merge multiple project files in a divided cc.json (#3743)
#3841
Feat(analysis): Add --large
merge - merge multiple project files in a divided cc.json (#3743)
#3841
Conversation
955dc14
to
86960be
Compare
Also updates the MergeFilter README (copied into gh-pages), updates tests for dialog and adds test for output file during mimo
86960be
to
53abd5d
Compare
Functionality is fine for me 👍 @IhsenBouallegue please do a code review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor nitpicks
...lter/MergeFilter/src/main/kotlin/de/maibornwolff/codecharta/filter/mergefilter/LargeMerge.kt
Outdated
Show resolved
Hide resolved
...lter/MergeFilter/src/main/kotlin/de/maibornwolff/codecharta/filter/mergefilter/LargeMerge.kt
Show resolved
Hide resolved
...lter/MergeFilter/src/main/kotlin/de/maibornwolff/codecharta/filter/mergefilter/LargeMerge.kt
Outdated
Show resolved
Hide resolved
...lter/MergeFilter/src/main/kotlin/de/maibornwolff/codecharta/filter/mergefilter/LargeMerge.kt
Outdated
Show resolved
Hide resolved
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
PR to Merge multiple projects files into one fat .cc.json
Closes: #3743
Closes: #3828
Description
--large
flag to the MergeFilterccsh merge --large ...
myProj.cc.json
->root/myProj/*
-o
option to mimo, to specify output folderDefinition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs