-
Notifications
You must be signed in to change notification settings - Fork 0
/
ISSUES
43 lines (32 loc) · 1.32 KB
/
ISSUES
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
Notes:
===============================================================================
Class differences/redundancies:
----------------------------------
This applies mainly to the new, smaller app: LoLTeamCheck
Each class is meant to only work on its own data - i.e. I want to avoid
importing classes into other classes.
Current issue: Redundant references
Classes: staticdata.py & rankeddata.py
In order to get ranked data for a champ for a summoner, I could use, in my GUI:
(1)
idnum = GrabStaticSata.get_champid("Jarvan IV")
stats = GrabRankedData.get_stats_by_id(idnum)
OR,
(2)
in GrabRankedData, I could sort the data from:
stats = api_instance.get_ranked_stats_by_summoner_id(id)
which comes as:
a list in stats['champions'], with stats['champions'][0]['stats'] &
stats['champions'][0]['id']
into:
new_stats['Jarvan IV'] with ['stats'] and ['id'] which means calling:
GrabStaticData.get_champid(name) for each champ
then use GrabRankedData.get_stats_by_name("Jarvan IV")
===============================================================================
Small QOL Stuff:
-------------------
1. Make sure champion names can be entered into the GUI in a case insensitive
form - i.e.:
(1) convert the static data list stored locally into a list with one case,
and,
(2) make sure the entry from the GUI gets converted before being checked.