Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ff and lovac in 2020 #907

Open
wants to merge 4 commits into
base: feat/data-setup-dagster
Choose a base branch
from

Conversation

rcourivaud
Copy link
Collaborator

No description provided.

Signed-off-by: Raphaël Courivaud <[email protected]>
Signed-off-by: Raphaël Courivaud <[email protected]>
Signed-off-by: Raphaël Courivaud <[email protected]>
Copy link

gitguardian bot commented Oct 7, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13776101 Triggered Notion Integration Token 3c9e749 analytics/dagster/src/assets/notion.py View secret
13776101 Triggered Notion Integration Token 9f91442 analytics/dagster/src/assets/notion.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: Raphaël Courivaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant