Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH dwidenoise: Soft component thresholding #3022

Open
Lestropie opened this issue Oct 9, 2024 · 1 comment
Open

ENH dwidenoise: Soft component thresholding #3022

Lestropie opened this issue Oct 9, 2024 · 1 comment

Comments

@Lestropie
Copy link
Member

Not familiar with what may be considered to be best practise here, but I at least have a basic sense of the concept.

Depending on where the upper threshold of the MP distribution is determined to be relative to the component eigenvalues, inclusion of components in the output DWI series could be fractional.

Lestropie added a commit that referenced this issue Nov 8, 2024
- Default behaviour is now to use optimal shrinkage based on minimisation of the Frobenius norm.
- Prior behaviour can be accessed using "-filter truncate".
Closes #3022.
@Lestropie
Copy link
Member Author

Animation below shows raw data, then denoising using eigenspectrum truncation, then optimal shrinkage.

@dchristiaens @jdtournier Would appreciate some input on the optimal shrinkage implementation:

  1. To make sure that my implementation is correct (some of the variable handling was already different to that in published manuscript)
  2. Given that the noise level threshold is determined based on choosing a specific component index, we want to make sure that the truncation / alignment of the optimal shrinkage function relative to that selection is correct; ie. check for off-by-one errors.

anim

@Lestropie Lestropie reopened this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant