From 5024143586151f8f99f7e588360920f6451cdcea Mon Sep 17 00:00:00 2001
From: Andrei Solodovnikov <VoultBoy@yandex.ru>
Date: Tue, 3 Oct 2023 00:40:53 +0300
Subject: [PATCH] =?UTF-8?q?=D0=9B=D0=A03.=20=D0=98=D1=81=D0=BF=D1=80=D0=B0?=
 =?UTF-8?q?=D0=B2=D0=BB=D0=B5=D0=BD=D0=B8=D0=B5=20=D1=82=D0=B1=20=D0=BF?=
 =?UTF-8?q?=D0=B0=D0=BC=D1=8F=D1=82=D0=B8=20=D0=B4=D0=B0=D0=BD=D0=BD=D1=8B?=
 =?UTF-8?q?=D1=85?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Тестбенч не выполнял проверку на запись данных
---
 .../tb_data_mem.sv                            | 38 +++++++++++--------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/Labs/03. Register file and memory/tb_data_mem.sv b/Labs/03. Register file and memory/tb_data_mem.sv
index 1f1e686c..e50fbfc4 100644
--- a/Labs/03. Register file and memory/tb_data_mem.sv	
+++ b/Labs/03. Register file and memory/tb_data_mem.sv	
@@ -40,11 +40,11 @@ parameter STEP = 8;
     .write_data_i   (WD),
     .read_data_o    (RD)
     );
-    
+
     logic [31:0] RDa;
-    integer i, err_count = 0;
+    integer i, hash, err_count = 0;
     assign A = i;
-    
+
     parameter CLK_FREQ_MHz   = 100;
     parameter CLK_SEMI_PERIOD= 1e3/CLK_FREQ_MHz/2;
 
@@ -57,14 +57,22 @@ parameter STEP = 8;
         REQ = 1;
         WE = 0;
         i = 0; #10;
-        if (RD !== 32'hx) begin
-            $display("The data memory should not be initialized by the $readmemh function");
-            err_count = err_count + 1;
+        @(posedge CLK);
+        for (i = 0; i < ADDR_SIZE; i = i + STEP) begin
+            hash = (i+4)*8/15*16/23*42;
+            WE = 1;
+            WD = hash;
+            @(posedge CLK);
         end
-        for (i = 0; i < ADDR_SIZE; i = i + 4) begin
+        WE = 0;
+        @(posedge CLK);
+        for (i = 0; i < ADDR_SIZE; i = i + STEP) begin
             @(posedge CLK);
-            WE = 1;
-            WD = $urandom;
+            hash = (i+4)*8/15*16/23*42;
+            if(RD !== hash) begin
+                $error("Read data: %0h is unequal written data: %0h at addres: %0h, time: %t", RD, hash, i, $time);
+                err_count = err_count + 1;
+            end
         end
         for (i = 0; i < (ADDR_SIZE+STEP); i = i + 1 + $urandom() % STEP) begin
             if (i < (ADDR_SIZE)) begin
@@ -77,11 +85,11 @@ parameter STEP = 8;
                 WE = $urandom % 2;
                 #TIME_OPERATION;
                 if ((WE && REQ || !REQ) && RD !== 32'd4195425967) begin
-                    $display("When writing (write_enable_i = %h) read_data_o should be equal to fa11_1eaf, your data: %h_%h, time: %t", WE, RD[31:16],RD[15:0], $time);
+                    $error("When writing (write_enable_i = %h) read_data_o should be equal to fa11_1eaf, your data: %h_%h, time: %t", WE, RD[31:16],RD[15:0], $time);
                     err_count = err_count + 1;
                 end
                 if ((!WE && REQ) && RD !== RDa) begin
-                    $display("When reading (write_enable_i = %h), the data %h is overwritten with data %h at address %h, time: %t", WE, RDa, RD, A, $time);
+                    $error("When reading (write_enable_i = %h), the data %h is overwritten with data %h at address %h, time: %t", WE, RDa, RD, A, $time);
                     err_count = err_count + 1;
                 end
             end
@@ -90,7 +98,7 @@ parameter STEP = 8;
                 REQ = 1;
                 #TIME_OPERATION;
                 if (RD !== 32'd3735928559) begin
-                    $display("When reading (write_enable_i = %h) at address greater than 16383 (current addr = %d), it should return dead_beef, but your data: %h_%h, time: %t", WE, A, RD[31:16],RD[15:0], $time);
+                    $error("When reading (write_enable_i = %h) at address greater than 16383 (current addr = %d), it should return dead_beef, but your data: %h_%h, time: %t", WE, A, RD[31:16],RD[15:0], $time);
                     err_count = err_count + 1;
                 end
             end
@@ -106,7 +114,7 @@ parameter STEP = 8;
             #1; RDa = RD;
           end else
           if(RD !== RDa) begin
-            $display("incorrect conversion of the reading address = %h, time: %t", A, $time);
+            $error("incorrect conversion of the reading address = %h, time: %t", A, $time);
             err_count = err_count + 1;
           end
           #TIME_OPERATION;
@@ -118,14 +126,14 @@ parameter STEP = 8;
         #1; RDa = RD;
         @(posedge CLK); #1;
         if (RD == RDa) begin
-            $display("reading from data memory must be synchronous, time: %t", $time);
+            $error("reading from data memory must be synchronous, time: %t", $time);
             err_count = err_count + 1;
         end
         @(posedge CLK);
         i = {14{1'b1}};
         repeat(2) @(posedge CLK);
         if (RD === 'd3735928559) begin
-            $display("incorrect reading from address = %d, data = %h", A, RD);
+            $error("incorrect reading from address = %d, data = %h", A, RD);
             err_count = err_count + 1;
         end
         $display("Number of errors: %d", err_count);