Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Change to ClassFileTransformer implementation #6

Open
Kasualix opened this issue Feb 29, 2024 · 3 comments
Open

[Fabric] Change to ClassFileTransformer implementation #6

Kasualix opened this issue Feb 29, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Kasualix
Copy link
Member

Kasualix commented Feb 29, 2024

Mixins are way less effective/compatible than ClassFileTransformer for Redirector.

Currently investigate how to register the transformer

https://github.com/MCTeamPotato/Redirector/blob/modern-fabric/src/main/java/com/teampotato/redirector/RedirectorTransformer.java

@Kasualix Kasualix added help wanted Extra attention is needed enhancement New feature or request labels Feb 29, 2024
@Kasualix Kasualix added bug Something isn't working and removed bug Something isn't working labels Mar 18, 2024
@Kasualix Kasualix changed the title [Fabric] Change to CoreMod implementation [Fabric] Change to ClassTransformer implementation Mar 21, 2024
@Ecdcaeb
Copy link
Collaborator

Ecdcaeb commented Mar 21, 2024

Fabric use launchwrapper, so use ITweak

@Kasualix
Copy link
Member Author

Kasualix commented Mar 21, 2024

https://github.com/FabricMC/fabric-loader/blob/master/minecraft/src/main/java/net/fabricmc/loader/impl/game/minecraft/launchwrapper/FabricClassTransformer.java
I was referring to this class earlier.

So if we create a transformer impl ITweaker like FabricTweaker, how can we register it and get it loaded into mc somewhere?

@Ecdcaeb
Copy link
Collaborator

Ecdcaeb commented Mar 22, 2024

use Launch.classLoader.registerTransformer in some early stage. ITweak is a early stage, but not the only one.
You could ask fabric for help. Find out how to create a coremod.
I am concerned that coremods are not supported, since fabric is built in mixin.(x

@Kasualix Kasualix changed the title [Fabric] Change to ClassTransformer implementation [Fabric] Change to ClassFileTransformer implementation Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants