Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify divider coding #21

Open
MBizm opened this issue Dec 28, 2019 · 0 comments
Open

Simplify divider coding #21

MBizm opened this issue Dec 28, 2019 · 0 comments
Labels
code quality cleanup of bulky or complex coding enhancement New feature or request help wanted Extra attention is needed

Comments

@MBizm
Copy link
Owner

MBizm commented Dec 28, 2019

The current divider implementation in Catatumbo/src/adafruit/controller/forecast/adafruit_forecast.py$setPixelBySampleboard(self, sampleboard, mask = -1) is rather bulky. Code simplification and the coverage of day shift in cases where bit mask covers whole day is required.
@MBizm MBizm added help wanted Extra attention is needed enhancement New feature or request code quality cleanup of bulky or complex coding labels Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality cleanup of bulky or complex coding enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MBizm