Skip to content
This repository has been archived by the owner on Jan 23, 2019. It is now read-only.

Issue: Translates <bool> tags #282

Open
Vankog opened this issue Dec 11, 2018 · 3 comments
Open

Issue: Translates <bool> tags #282

Vankog opened this issue Dec 11, 2018 · 3 comments

Comments

@Vankog
Copy link

Vankog commented Dec 11, 2018

General information

Hi there, again coming from AdAway. :-)
(Unfortunately, we still cannot incorporate your user's contributions into our Transifex workflow.)
Nonetheless I realized something strange in the PRs that I wanted to bring to your attention.

Stringlate tries to translate <bool> tags.
See: https://github.com/AdAway/AdAway/pull/1088/files#diff-5cade5cbcadc3db19ceae964e0bbfef5

This has potential for massive misbehavior in apps, because "true" is not parseable any more when translated.

Hope this helps!

Best regards!

@Vankog Vankog changed the title Issue: Translates <bool> tags Issue: Translates <bool> tags Dec 11, 2018
@Vankog Vankog changed the title Issue: Translates <bool> tags Issue: Translates <bool> tags Dec 11, 2018
@Lonami
Copy link
Member

Lonami commented Dec 11, 2018

That's weird, "bool" is not known and readResourcesInto skips unknown values (quick look from my phone).

@Vankog
Copy link
Author

Vankog commented Dec 11, 2018

Might it be that it does not translate, but just copies the entries from the raw/values folder to keep the file consistent?
But in that case, the other <string translatable=false ...> entries in that file weren't copied.

(Just a side question, because I'm curious:
is


case insensitive somewhere?
In the getName() docs there is no mention if it always returns lower case.)

@Lonami
Copy link
Member

Lonami commented Dec 11, 2018

(Good point, a case-insensitive switch should be made. Guess I assumed nobody doing XML shouts :))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants