Skip to content
This repository has been archived by the owner on Jan 23, 2019. It is now read-only.

PR explanation #227

Open
CrimsonFork opened this issue Jun 5, 2018 · 7 comments
Open

PR explanation #227

CrimsonFork opened this issue Jun 5, 2018 · 7 comments

Comments

@CrimsonFork
Copy link

It would be nice if SL had an explanation about PRs im the help section.

Like, I am a noob and I don't really know what it does, but people keep suggesting I should use them, but when I try, it says it will clone the repo, which does not sound like something I want, but I have no idea.

@licaon-kter
Copy link
Contributor

Yes. You fork the repo actually (Github does) and you commit your modifications to your repo, then you open a PR from your repo with these changes to the original repo for integration in there.

Read about how Github works.

@CrimsonFork
Copy link
Author

CrimsonFork commented Jun 5, 2018 via email

@CrimsonFork
Copy link
Author

CrimsonFork commented Jun 5, 2018 via email

@Lonami
Copy link
Member

Lonami commented Jun 5, 2018

We could probably add a section to help/en.md explaining what "PR" or "Pull Request" means.

@CrimsonFork
Copy link
Author

CrimsonFork commented Jun 5, 2018 via email

@Lonami
Copy link
Member

Lonami commented Jun 5, 2018

Yes, that file is what the question mark uses.

@CrimsonFork
Copy link
Author

CrimsonFork commented Jun 5, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants