-
Notifications
You must be signed in to change notification settings - Fork 46
Allow to submit changes for original strings #156
Comments
The original string is kept as readonly because if you modified it there would be no turning back, other than synchronizing again. So perhaps a better approach would be to have a special locale "Fix up" or "Patches" (please suggest more names!) for the original translation, that would simply be initialized with a fresh copy of the English (default locale) strings. |
From a ui perspective, I would not do it any differently than any other language: Allow modifying the [English] translation (the same way it's possible to modify any other 100% translated language), and exporting it via clipboard, gist, PR, etc. Keep the "original string" field as-is until changes are merged to origin/master. On the backend, that probably means either caching the source strings or loading them from the index instead of the working directory. However, that's just an implementation detail to me. |
Problem is the default locale may not be English. There's no way to tell this, so "[English]" wouldn't be a valid name. Yes, the implementation would be something like a "special" locale which would just be special on creation/exporting to pull request. Nothing really fancy. The thing is, what name should we give to this locale? |
I meant the brackets to indicate I knew it wouldn't always be English, lol. They use "Default" here. I think "Source" or "Master" would also work well. Or just adding slightly more description, like, "Default (all locales)". |
values-fix :D |
If I'd like to send a PR suggesting an update to the phrasing of English/source strings, I don't see why that should be prevented. Seems like an easy win :)
The text was updated successfully, but these errors were encountered: