Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML instructions are hard to read #455

Open
cgutteridge opened this issue Nov 12, 2024 · 5 comments
Open

SAML instructions are hard to read #455

cgutteridge opened this issue Nov 12, 2024 · 5 comments

Comments

@cgutteridge
Copy link

SAML is already quite hard to understand and https://github.com/LibreBooking/app/wiki/SAML-Configuration is too dense.

Please could you break it up so that each instruction is in a clearly separated paragraph or bullet point. It would make a huge difference.

eg. layout the main settings with breaks:

baseurlpath should be updated to the full path of the SimpleSAMLphp www directory. If you followed the above advice and created a subdomain, this should be something like https://saml.yourdomain.com/

technicalcontact_email should be set to your email address (or anyone responsible for managing SSO integrations) secretsalt should be set to any secure, random value.

auth.adminpassword should be set to any secure, random value.

@JohnVillalovos
Copy link
Contributor

I would suggest you propose a PR with your suggested changes. This will be the most likely and fastest way for this to be done.

@cgutteridge
Copy link
Author

Happy to, but I can't see how to do a PR on a github wiki. Google suggests it may not be an option.

@JohnVillalovos
Copy link
Contributor

Maybe take what is in the Wiki and add it to the doc/ directory in the repository?

@cgutteridge
Copy link
Author

Sure. I'm literally working through these now and needed to break them into bits to get my brain around them anyway.

I'll wait until I've done all the steps and got it working and add any more useful notes then send you a PR, or you can copy the markdown into the wiki.

https://github.com/cgutteridge/librebooking-app/blob/develop/doc/SAML-Configuration.md

@JohnVillalovos
Copy link
Contributor

FYI: I'm not the maintainer. And I don't have permission to modify the wiki. The maintainer has said he is very busy. He has been able to review things, but he doesn't seem to have the time to create the fixes for issues, for the most part.

But on PRs I have proposed he has usually reviewed them within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants