Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add users to client when created #2559

Open
LufinityLucas opened this issue Jun 22, 2024 · 1 comment
Open

[FEATURE] Add users to client when created #2559

LufinityLucas opened this issue Jun 22, 2024 · 1 comment

Comments

@LufinityLucas
Copy link

Is your feature request related to a problem? Please describe.
When new users are created during, in my case, the OIDC login process (by setting $oidcCreateUser to true), they are not member of any client and as such do not have access to any projects. A nice feature would be to have them added to a specified default client.

Describe the solution you'd like
This should probably have been a pull request, but I'm to unsure how to do one properly. 😄

In /app/Domain/Oidc/Services/Oidc.php, add e.g.,

...
private int $defaultClient = 0;
...
$this->defaultClient = $this->config->get('oidcDefaultClient', 0);
...

And in the same file when running the createUser method, change 'clientId' => '' to 'clientId' => $this->defaultClient,

At last, add it to wherever default configurations are stored, e.g., in /app/Core/DefaultConfig.php, add public int $oidcDefaultClient = 0;.

@marcelfolaron
Copy link
Contributor

I like that. We should do that. Will keep this in mind for our next iteration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants