Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android only] Show current frame of video as TrimSlider is being used #110

Open
charlieforward9 opened this issue Oct 27, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@charlieforward9
Copy link

I would like to see the exact frame of the video when using the trim slider. Most video croppers have the ability to see the current frame when trimming for more accurate, real-time trimming. This would be a huge value-add to this package, bringing it closer to native-app-level UX.

I figure the best way to do this is to combine the video player and trim slider widgets into a single widget and put the functionality within that combined widget), I am on a deadline with a client, but if the app I am building proves to be a success, I may try to design it.

Would love to know if this already exists and I am missing it, and/or any further feedback on this functionality!

@charlieforward9 charlieforward9 changed the title Show current frame of video as TrimSlider is being used [Feature Request] Show current frame of video as TrimSlider is being used Oct 27, 2022
@LeGoffMael
Copy link
Owner

Hello,

Yes this is a feature i also wanted to implements but it seems that the seekTo function of the flutter video controller does not update the video frame directly.

The trim slider and video player are supposed to be already synch using the VideoEditorController. I think we should only wait for the flutter video_player lib to fix this feature.

some related issues : flutter/flutter#78998, flutter/flutter#80054, flutter/flutter#72416.

Anyway you're welcome to open a PR if you find a solution !

@charlieforward9
Copy link
Author

If I understand correctly, the related flutter issues are required to be closed before this issue can be resolved? Thanks for the response!

@LeGoffMael
Copy link
Owner

Pleach check out the new 2.0.0 version which seems better on iOS platform, however it is still not updating directly on android

@charlieforward9
Copy link
Author

My project is iOS only, so this was exactly what I needed. Thank you so much for the new versions! This solves my problem specifically, so I am happy to close this issue. I will leave that up to you though, given Android is still problematic.

@LeGoffMael LeGoffMael changed the title [Feature Request] Show current frame of video as TrimSlider is being used [Android only] Show current frame of video as TrimSlider is being used Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@LeGoffMael @charlieforward9 and others