From 15b08b5b6246c50405807a6b5d88358f8638e5ee Mon Sep 17 00:00:00 2001 From: "clandestine.eth" <96172957+0xClandestine@users.noreply.github.com> Date: Tue, 17 Sep 2024 14:43:04 -0400 Subject: [PATCH 1/3] fix: fail on storage diff --- .github/workflows/storage-report.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/storage-report.yml b/.github/workflows/storage-report.yml index f99082670..d4665b015 100644 --- a/.github/workflows/storage-report.yml +++ b/.github/workflows/storage-report.yml @@ -12,6 +12,7 @@ jobs: - uses: actions/checkout@v4 with: submodules: recursive + - name: Install Foundry uses: foundry-rs/foundry-toolchain@v1 with: @@ -34,6 +35,9 @@ jobs: - name: Compare outputs run: | - if ! diff --unified pr target; then - echo "::warning::Differences found between PR and target branch storage layouts" - fi \ No newline at end of file + if diff --unified pr target; then + echo "No differences found" + else + echo "::error::Differences found between PR and target branch storage layouts" + exit 1 + fi From d62ebe1d42318385855ed1683dfec777119053e1 Mon Sep 17 00:00:00 2001 From: "clandestine.eth" <96172957+0xClandestine@users.noreply.github.com> Date: Tue, 17 Sep 2024 14:49:07 -0400 Subject: [PATCH 2/3] test(ci): add variable to see if ci fails --- src/contracts/core/AVSDirectoryStorage.sol | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/contracts/core/AVSDirectoryStorage.sol b/src/contracts/core/AVSDirectoryStorage.sol index 47a326f16..091ed6f8d 100644 --- a/src/contracts/core/AVSDirectoryStorage.sol +++ b/src/contracts/core/AVSDirectoryStorage.sol @@ -23,6 +23,8 @@ abstract contract AVSDirectoryStorage is IAVSDirectory { */ bytes32 internal _DOMAIN_SEPARATOR; + uint256 public _TEST_CI; + /// @notice Mapping: AVS => operator => enum of operator status to the AVS mapping(address => mapping(address => OperatorAVSRegistrationStatus)) public avsOperatorStatus; From 87c09746eba566122f969706011c4123cc159cf5 Mon Sep 17 00:00:00 2001 From: "clandestine.eth" <96172957+0xClandestine@users.noreply.github.com> Date: Tue, 17 Sep 2024 14:51:43 -0400 Subject: [PATCH 3/3] test(ci): remove variable --- src/contracts/core/AVSDirectoryStorage.sol | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/contracts/core/AVSDirectoryStorage.sol b/src/contracts/core/AVSDirectoryStorage.sol index 091ed6f8d..47a326f16 100644 --- a/src/contracts/core/AVSDirectoryStorage.sol +++ b/src/contracts/core/AVSDirectoryStorage.sol @@ -23,8 +23,6 @@ abstract contract AVSDirectoryStorage is IAVSDirectory { */ bytes32 internal _DOMAIN_SEPARATOR; - uint256 public _TEST_CI; - /// @notice Mapping: AVS => operator => enum of operator status to the AVS mapping(address => mapping(address => OperatorAVSRegistrationStatus)) public avsOperatorStatus;