From 5cfbf596085707a08aa33bf6d023eb5281527715 Mon Sep 17 00:00:00 2001 From: Jian Xiao Date: Tue, 2 Jul 2024 19:39:13 +0000 Subject: [PATCH 1/3] Log request serialization time --- disperser/batcher/grpc/dispatcher.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disperser/batcher/grpc/dispatcher.go b/disperser/batcher/grpc/dispatcher.go index 533acb53e..ce224382e 100644 --- a/disperser/batcher/grpc/dispatcher.go +++ b/disperser/batcher/grpc/dispatcher.go @@ -125,13 +125,13 @@ func (c *dispatcher) sendChunks(ctx context.Context, blobs []*core.BlobMessage, gc := node.NewDispersalClient(conn) ctx, cancel := context.WithTimeout(ctx, c.Timeout) defer cancel() + start := time.Now() request, totalSize, err := GetStoreChunksRequest(blobs, batchHeader) if err != nil { return nil, err } - + c.logger.Debug("sending chunks to operator", "operator", op.Socket, "size", totalSize, "request message size", proto.Size(request), "num blobs", len(blobs), "request serialization time", time.Since(start)) opt := grpc.MaxCallSendMsgSize(60 * 1024 * 1024 * 1024) - c.logger.Debug("sending chunks to operator", "operator", op.Socket, "size", totalSize, "request message size", proto.Size(request)) reply, err := gc.StoreChunks(ctx, request, opt) if err != nil { From 340a561f96b4e8a61a2038a002ba15827669b563 Mon Sep 17 00:00:00 2001 From: Jian Xiao Date: Tue, 2 Jul 2024 19:41:20 +0000 Subject: [PATCH 2/3] order --- disperser/batcher/grpc/dispatcher.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disperser/batcher/grpc/dispatcher.go b/disperser/batcher/grpc/dispatcher.go index ce224382e..5807a6f40 100644 --- a/disperser/batcher/grpc/dispatcher.go +++ b/disperser/batcher/grpc/dispatcher.go @@ -130,7 +130,7 @@ func (c *dispatcher) sendChunks(ctx context.Context, blobs []*core.BlobMessage, if err != nil { return nil, err } - c.logger.Debug("sending chunks to operator", "operator", op.Socket, "size", totalSize, "request message size", proto.Size(request), "num blobs", len(blobs), "request serialization time", time.Since(start)) + c.logger.Debug("sending chunks to operator", "operator", op.Socket, "num blobs", len(blobs), "size", totalSize, "request message size", proto.Size(request), "request serialization time", time.Since(start)) opt := grpc.MaxCallSendMsgSize(60 * 1024 * 1024 * 1024) reply, err := gc.StoreChunks(ctx, request, opt) From 436b104a67fad3bfd5d67b963f285435c3e85923 Mon Sep 17 00:00:00 2001 From: Jian Xiao Date: Mon, 8 Jul 2024 16:48:53 +0000 Subject: [PATCH 3/3] fix typo --- node/grpc/server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/node/grpc/server.go b/node/grpc/server.go index d9710ca82..45f77c150 100644 --- a/node/grpc/server.go +++ b/node/grpc/server.go @@ -209,7 +209,7 @@ func (s *Server) StoreChunks(ctx context.Context, in *pb.StoreChunksRequest) (*p } } // Caveat: proto.Size() returns int, so this log will not work for larger protobuf message (over about 2GiB). - s.node.Logger.Info("StoreChunks RPC request recieved", "num of blobs", len(in.Blobs), "request message size", proto.Size(in), "total size of blob headers", blobHeadersSize, "total size of bundles", bundleSize) + s.node.Logger.Info("StoreChunks RPC request received", "num of blobs", len(in.Blobs), "request message size", proto.Size(in), "total size of blob headers", blobHeadersSize, "total size of bundles", bundleSize) // Validate the request. if err := s.validateStoreChunkRequest(in); err != nil {