Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [credit_tracker_table] in a widget #18

Open
r-brown opened this issue Nov 27, 2015 · 7 comments
Open

Use [credit_tracker_table] in a widget #18

r-brown opened this issue Nov 27, 2015 · 7 comments
Labels
enhancement hacktoberfest Hacktoberfest ready issue

Comments

@r-brown
Copy link
Member

r-brown commented Nov 27, 2015

Can [credit_tracker_table] somehow be used in or as a widget? I tried that but the code is not interpreted unfortunately.

Our goal was to show the copyright table in the footer area instead of below the article.

Source: https://wordpress.org/support/topic/credit-tracker-table-in-widget

@r-brown r-brown self-assigned this Nov 27, 2015
@r-brown r-brown added the hacktoberfest Hacktoberfest ready issue label Oct 2, 2017
@Jaace
Copy link
Contributor

Jaace commented Oct 20, 2017

Do you mind if I look into this?

@r-brown
Copy link
Member Author

r-brown commented Oct 20, 2017

Hi @Jaace - absolutely, thank you for your support!

@Jaace
Copy link
Contributor

Jaace commented Oct 21, 2017

@r-brown I've opened a PR for this here: #28

@r-brown
Copy link
Member Author

r-brown commented Oct 21, 2017

There is still one issue open - image preview isn't rendered in the widget if all available columns are shown (e.g. no values in the field Include Columns).

ct-small-image

As soon as custom fields are added to this field - preview image is rendered

ct-credit-table

@Jaace
Copy link
Contributor

Jaace commented Oct 21, 2017

I'll take a look into this bug

@Jaace
Copy link
Contributor

Jaace commented Oct 21, 2017

@r-brown
This appears to be related to the styling in the theme being used. I see this happening in Twenty Seventeen, but if I install Twenty Sixteen, I can see all tables rendering properly, including those within widgets.

Some screenshots:
Twenty Seventeen, post_content
post content

Twenty Seventeen, footer 1 "sidebar", as a widget.
widget

Twenty Sixteen, post_content:
post content

Twenty Sixteen, content bottom 1 "sidebar", as a widget.
footer

@r-brown
Copy link
Member Author

r-brown commented Oct 22, 2017

Possibly we need to override some styles at css/ct-public.css (style: table.credit-tracker-xxx), so the table is rendered correctly regardless of the chosen theme.

@r-brown r-brown removed their assignment Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest Hacktoberfest ready issue
Development

No branches or pull requests

2 participants