Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config filename typo: gx5_25.yml vs gx5_15.yml #320

Closed
GreatAlexander opened this issue Apr 9, 2024 · 1 comment
Closed

Config filename typo: gx5_25.yml vs gx5_15.yml #320

GreatAlexander opened this issue Apr 9, 2024 · 1 comment
Labels
bug Something isn't working New This issue is new, and should not be marked as stale

Comments

@GreatAlexander
Copy link

Describe the bug
Minor filename typo.
Config file should be gx5_15.yml not gx5_25.yml in the gx5_15 folder (ros2 branch).
https://github.com/LORD-MicroStrain/microstrain_inertial/blob/ros2/microstrain_inertial_examples/config/gx5_15/gx5_25.yml

To Reproduce
Launch the gx5_15 example launch file which points to a non-existent file.

Expected behavior
Example launch file works correctly

Environment (please complete the following information):

  • OS: Ubuntu 22.04
  • Architecture: Docker [ros:humble-ros-base-jammy]
  • ROS Version: Humble
  • Version: Latest ros2 branch [source]
  • Sensor(s): 3DM-GX5-15

Additional context
While setting up our own launch repo based on the examples, we noticed this naming inconsistency. Apologies if this is not the right process / we've missed something.

@GreatAlexander GreatAlexander added the bug Something isn't working label Apr 9, 2024
@github-actions github-actions bot added the New This issue is new, and should not be marked as stale label Apr 9, 2024
@robbiefish
Copy link

Thanks for pointing that out and making the PR. Just merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working New This issue is new, and should not be marked as stale
Projects
None yet
Development

No branches or pull requests

2 participants