Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB20: reduce asset name length limit #74

Open
zoedberg opened this issue Nov 4, 2020 · 7 comments
Open

RGB20: reduce asset name length limit #74

zoedberg opened this issue Nov 4, 2020 · 7 comments
Labels
question Further information is requested [RGB] Specs related to client-validated state management system

Comments

@zoedberg
Copy link
Member

zoedberg commented Nov 4, 2020

Currently there's an enforcement at schema level of 256 chars on the asset name.

This limit may be too high, so let's consider lowering it a bit.

@dr-orlovsky dr-orlovsky transferred this issue from RGB-WG/rgb-node Nov 6, 2020
@dr-orlovsky dr-orlovsky added [RGB] Specs related to client-validated state management system question Further information is requested labels Nov 6, 2020
@dr-orlovsky dr-orlovsky added this to the RGB schemata v1 milestone Nov 6, 2020
@fedsten
Copy link
Member

fedsten commented Nov 10, 2020

Which potential issues do you see by keeping the limit at the current level?

@zoedberg
Copy link
Member Author

Which potential issues do you see by keeping the limit at the current level?

I think that usually asset names will be short (e.g. ticker: "USDT" -> name: "USD Tether").

IMO allowing 256 chars can't cause dangerous issues, but from an interface perspective, every developer in every software that wants to show that info, will have to consider that potentially someone created an asset with a very long name. That's not a funny thing to deal with, especially if most of asset names are short and just one isn't.

So I think we need a reason to keep it so long, not the opposite.

My suggestion is to use 32 chars, it should be enough.

@fedsten
Copy link
Member

fedsten commented Nov 11, 2020

Fair point, I agree with the proposal of reducing the chars limit to 32

@St333p
Copy link
Member

St333p commented Nov 12, 2020

I agree, a 32 chars limit helps to clarify the intended purpose of the "name" field.

@weedcoder
Copy link

in liquid, there is no asset name.
if you want to have a name, you have to register against blockstream registry and have some cryptographic proofs in a https served .well-know files.
you can assign asset name manually in the client configuration file, not really practical.
here is the documentation : https://docs.blockstream.com/liquid/developer-guide/proof-of-issuance.html

@nicbus
Copy link
Member

nicbus commented Nov 13, 2020

  • the longest currency name in wikipedia's List of circulating currencies is Bosnia and Herzegovina convertible mark with 39 characters
  • the longest ERC20 token name (according to etherscan.io is Yee with 46 characters (Yee - A Blockchain-powered & Cloud-based Socia) or 40 when ignoring the leading Yee - (also, looks like it's been truncated)

the answer might be 42 😏

@dr-orlovsky
Copy link
Member

I think we need 37

image

UkolovaOlga added a commit to LNP-BP/devcalls that referenced this issue Nov 22, 2020
Agenda of the call:
1. RGB [branding](https://github.com/LNP-BP/FAQ/tree/master/RGB%20Branding%20%26%20Logo) update
2. [Reduce asset name length limit] (LNP-BP/LNPBPs#74)
3. [Support for asset name registries] (LNP-BP/LNPBPs#75)
4. [PSBT and deterministic bitcoin commitments / public key tweaks] (LNP-BP/LNPBPs#69)
5. RGB Schema update:
- Removed dust limit
- Multiple inflation rights with better control over total inflation
- Epoch-based burn and burn-and-replace procedures; enhanced with UTXO set and versioned proofs of burn data, supporting up to 15 burn proof variants (+"no proofs" option)
- Asset renomination procedure, for changing asset names or splitting stock shares after @sabina_sa proposal
- Standardization of contract text URL and commitment format
- Rights split procedure
@dr-orlovsky dr-orlovsky changed the title reduce asset name length limit RGB20: reduce asset name length limit Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested [RGB] Specs related to client-validated state management system
Projects
None yet
Development

No branches or pull requests

6 participants