Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsframe functions are currently sorted by default #215

Open
Yejashi opened this issue Oct 21, 2024 · 0 comments
Open

Statsframe functions are currently sorted by default #215

Yejashi opened this issue Oct 21, 2024 · 0 comments
Labels
area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs

Comments

@Yejashi
Copy link
Collaborator

Yejashi commented Oct 21, 2024

As it currently stands, there is a precedent in Thicket such that all statsframe operations sort the statsframe dataframe. This is extra behavior that is done on the behalf of the user.

For some context, Treecs seems to have added this behavior in over a year ago.

Given this, i propose two options:

  1. Keep things as is. Ever statsframe functionality here forth will enforce a standard that entail ts the sorting of the statsframe dataframe.
  2. We remove the default sorting and instead create a function available to the user that does the work of sorting the statsframe dataframe.
@Yejashi Yejashi added area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs
Projects
None yet
Development

No branches or pull requests

1 participant