Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiIndex for ExtraP Functions #15

Open
michaelmckinsey1 opened this issue Apr 28, 2023 · 0 comments
Open

Use MultiIndex for ExtraP Functions #15

michaelmckinsey1 opened this issue Apr 28, 2023 · 0 comments
Labels
area-extrap Issues and PRs involving Thicket's support for Extra-P priority-normal Normal priority issues and PRs type-feature Requests for new features or PRs which implement new features

Comments

@michaelmckinsey1
Copy link
Collaborator

The componentize_statsframe and _add_extrap_statistics extrap model functions both add a lot of columns to the statsframe.

Statsframe

avg#inclusive#sum#time.duration_extrap-model avg#inclusive#sum#time.duration_RSS_extrap-model avg#inclusive#sum#time.duration_rRSS_extrap-model ...
cell cell cell cell
cell cell cell cell

Currently, we are appending strings to the column name to distinguish them between each other. This becomes very messy fast and is not user friendly. I propose pulling out the common strings between the columns, like avg#inclusive#sum#time.duration, into a higher-level column index, and let the different strings distinguish each column, like model, RSS, rRSS.

And what if our statsframe already had other statistics and/or models in it? Our problem would only become worse. So I believe we can leverage multi-indexing to help us organize the statsframe.

@ilumsden ilumsden added area-extrap Issues and PRs involving Thicket's support for Extra-P priority-normal Normal priority issues and PRs type-feature Requests for new features or PRs which implement new features labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-extrap Issues and PRs involving Thicket's support for Extra-P priority-normal Normal priority issues and PRs type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

No branches or pull requests

2 participants