Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable installs break due to setuptools #133

Open
ilumsden opened this issue Feb 14, 2024 · 3 comments
Open

Editable installs break due to setuptools #133

ilumsden opened this issue Feb 14, 2024 · 3 comments
Labels
area-deployment Issues and PRs involving Thicket's packaging and deployment priority-urgent Urgent priority issues and PRs type-bug Identifies bugs in issues and identifies bug fixes in PRs type-feature Requests for new features or PRs which implement new features

Comments

@ilumsden
Copy link
Collaborator

As reported here, there is a bug in newer versions of setuptools that can caused editable installs to break due to changes that setuptools made to support PEP 600.

There are two ways to address this. In the short term, users can add --config-settings editable_mode=strict to their pip install -e command. This forces setuptools to use the older style of editable installs. Longer term, the best way to fix this for Hatchet and Thicket is to move away from setuptools.
@ilumsden ilumsden added area-deployment Issues and PRs involving Thicket's packaging and deployment priority-urgent Urgent priority issues and PRs type-bug Identifies bugs in issues and identifies bug fixes in PRs type-feature Requests for new features or PRs which implement new features labels Feb 14, 2024
@ilumsden
Copy link
Collaborator Author

Regarding editable_mode, this page from setuptools explains what it does: https://setuptools.pypa.io/en/latest/userguide/development_mode.html#strict-editable-installs

@ilumsden
Copy link
Collaborator Author

ilumsden commented Mar 4, 2024

We ran into a case where editable_mode does not fix this issue

@ilumsden
Copy link
Collaborator Author

See #135 and LLNL/hatchet#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-deployment Issues and PRs involving Thicket's packaging and deployment priority-urgent Urgent priority issues and PRs type-bug Identifies bugs in issues and identifies bug fixes in PRs type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilumsden