Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct primal values in the sensitivity calls #1014

Open
jamiebramwell opened this issue Oct 19, 2023 · 1 comment
Open

Use correct primal values in the sensitivity calls #1014

jamiebramwell opened this issue Oct 19, 2023 · 1 comment

Comments

@jamiebramwell
Copy link
Member

As written, the sensitivity calculation calls in the HeatTransfer and SolidMechanics modules will not use the correct primal field values (e.g. temperature) during the backward adjoint pass. See

std::array<std::function<decltype((*residual_)(DifferentiateWRT<0>{}, temperature_, temperature_rate_,
shape_displacement_, *parameters_[parameter_indices].state...))()>,
sizeof...(parameter_indices)>
d_residual_d_ = {[&]() {
return (*residual_)(DifferentiateWRT<NUM_STATE_VARS + parameter_indices>{}, temperature_, temperature_rate_,
shape_displacement_, *parameters_[parameter_indices].state...);
}...};
.

@btalamini
Copy link
Collaborator

We should check that the correct time is used as well. Ideally, we should write tests that fail before patching the bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants